Skip to content

feat(snapshot): deploy opted-in tmpfs PageBroker - #13168

Closed
dfeigin-nv wants to merge 1 commit into
pagebroker-restorefrom
pagebroker-kubernetes
Closed

feat(snapshot): deploy opted-in tmpfs PageBroker#13168
dfeigin-nv wants to merge 1 commit into
pagebroker-restorefrom
pagebroker-kubernetes

Conversation

@dfeigin-nv

@dfeigin-nv dfeigin-nv commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds the opt-in PageBroker sidecar, shared tmpfs staging, and control socket mounts.

Validation: helm lint deploy/helm/charts/snapshot; enabled and disabled renders; invalid podMount rejected.

@github-actions github-actions Bot added feat deployment::k8s Relates to dynamo deployment in kubernetes labels Aug 13, 2026
@dfeigin-nv
dfeigin-nv marked this pull request as ready for review August 13, 2026 08:03
@dfeigin-nv
dfeigin-nv requested a review from a team as a code owner August 13, 2026 08:03
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Aug 13, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread deploy/helm/charts/snapshot/templates/daemonset.yaml
Comment thread deploy/helm/charts/snapshot/values.yaml Outdated
@datadog-official

datadog-official Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 3 Pipeline jobs failed

Pre Merge | pre-commit   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Generated files are not up to date after running pre-commit hooks. Please run 'pre-commit install' and commit the changes.

Docs link check | lychee   View in Datadog   GitHub Actions

See error Dependency errors encountered: multiple 404 Not Found responses when attempting to access external documentation links.

Pre Merge | pre-merge-status-check   View in Datadog   GitHub Actions

📋 Copy prompt for your agent 
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: pagebroker-kubernetes

Pre Merge | pre-commit
Commit: 1403a9662eaaa35b5da2ecca47514dfbc7ca0c66
Error (code / build):
Generated files are not up to date after running pre-commit hooks. Please run 'pre-commit install' and commit the changes.
CI job: https://github.com/ai-dynamo/dynamo/actions/runs/31950891645/job/95174069736

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 50.31% (-0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1403a96 | Docs | Datadog PR Page | Give us feedback!

@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch from 51e6cd5 to cc1fda4 Compare August 13, 2026 08:42
This was referenced Aug 13, 2026
Closed
Closed
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch from cc1fda4 to 822ee5e Compare August 13, 2026 11:59
@dfeigin-nv dfeigin-nv mentioned this pull request Aug 13, 2026
Closed
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch from 822ee5e to 9f0bf20 Compare August 16, 2026 08:45
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch 2 times, most recently from 369ba22 to 83804cd Compare August 16, 2026 10:16
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch from 83804cd to 81101e7 Compare August 16, 2026 10:34
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch from 81101e7 to ef93e6f Compare August 16, 2026 11:33
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch from ef93e6f to a6be881 Compare August 16, 2026 13:29
@dfeigin-nv
dfeigin-nv force-pushed the pagebroker-kubernetes branch from a6be881 to 1403a96 Compare August 16, 2026 13:48
@dfeigin-nv dfeigin-nv mentioned this pull request Aug 20, 2026
Open
@dfeigin-nv

dfeigin-nv commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Moved to ai-dynamo/snapshot#91.

@dfeigin-nv dfeigin-nv closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
+1 more reviewer
@dynamo-review-agent dynamo-review-agent[bot] dynamo-review-agent[bot] approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deployment::k8s Relates to dynamo deployment in kubernetes feat size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dfeigin-nv